puppetlabs / cat-github-actions

1 stars 4 forks source link

(CAT-1618) - Fix issue with concurrent coverage report uploads #73

Closed jordanbreen28 closed 6 months ago

jordanbreen28 commented 6 months ago

Summary

Multiple concurrent coverage report uploads will cause the steps to fail on GHA. We only need to upload the coverage report once per repo, so it makes sense anyway to remove these duplicate uploads.

Additional Context

See here for example: https://github.com/puppetlabs/puppetfile-resolver/actions/runs/7530251054/job/20496211429?pr=5

Inspired by solution here https://github.com/codecov/codecov-action/issues/40, seems there is no real elegant way to do this but to limit it to the factors of your CI matrixes.

Can be seen working here - https://github.com/puppetlabs/puppetfile-resolver/actions/runs/7530785534/job/20497934824

Notice the step only executes in the job ubuntu-latest ruby 3.2

Checklist