CAT-1918 : Update module_release.yml

malikparvez commented 1 month ago

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

[ ] Root cause and the steps to reproduce. (If applicable)
[ ] Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

[ ] 🟢 Spec tests.
[ ] 🟢 Acceptance tests.
[ ] Manually verified.

h0tw1r3 commented 1 week ago

@malikparvez @gavindidrichsen

Asking because there was no context at all in the commit or PR, what was the purpose of reverting all of these changes?

The reverted changes gave a much improved release change output, ability to retry a failed publishing to the forge, fixed tagging releases with annotated tags, and much more.

This breaks the ability to use this workflow to release puppet-toy-chest modules.

Most of the reverted changes were from the PR: https://github.com/puppetlabs/cat-github-actions/pull/88

malikparvez commented 1 week ago

Hey @h0tw1r3 sorry to revert your changes, considering the security module deployment is very critical activity so we decided to keep it very vanilla without much options. You can see refer #98

puppetlabs / cat-github-actions