search

puppetlabs / clj-http-client

HTTP client library wrapping Apache HttpAsyncClient
Apache License 2.0
15 stars 30 forks source link

(TK-103) Rework client close and remove support for "single request" async APIs #24

Closed camlow325 closed 9 years ago

camlow325 commented 9 years ago

This PR contains two major changes:

1) Reworked how close is called on a CloseableHttpAsyncClient after a synchronous "single request" -- a request without the caller having to manage a client instance -- has completed. This removes the temporary workaround done in TK-101 - https://github.com/puppetlabs/clj-http-client/pull/21 - to handle client closing.

2) Rather than rework the asynchronous "single request" API with a better "close" implementation, this PR removes the asynchronous "single request" API completely. It is believed that these API was not in use anyway in that async consumers would more likely have already been using the "with-client" API at the Clojure level. At the Java layer, this will leave a temporary void in the ability to do async requests since no "with-client" Java API exists. A "with-client" Java API is planned for TK-108.

camlow325 commented 9 years ago

I'm going to close this PR since it will need to be reworked after TK-108, #25, goes in anyway.