search

puppetlabs / clj-http-client

HTTP client library wrapping Apache HttpAsyncClient
Apache License 2.0
15 stars 30 forks source link

(TK-303) Update to latest apache httpasyncclient #43

Closed cprice404 closed 8 years ago

cprice404 commented 8 years ago

This commit updates us to the latest version of the Apache HTTPAsyncClient. This is necessary in order to make it possible to use this library in the same VM as the latest version of clj-http, because they have some common dependencies.

The commit also cleans up some other dependencies while I was in there.

scottyw commented 8 years ago

LGTM

camlow325 commented 8 years ago

:+1: Can merge assuming we don't want to do anything else about the decompression issue we discussed in other comments on the PR.

cprice404 commented 8 years ago

@scottyw do you have any rough ideas as to when you might have bandwidth to revisit that stuff? I'm trying to decide whether we need to file any additional tickets and/or prioritize them before we merge this, or whether TK-179 is sufficient.

scottyw commented 8 years ago

I feel like the Java work to support "unbuffered stream" is a prerequisite for TK-179. I don't think we're ever likely to have the Java API make use of any of the Clojure paths - it'll always be the Clojure API sharing some of the Java paths.

If it works for you, I'll add a ticket to implement unbuffered streams in Java with a stretch goal to dovetail in with TK-179.

cprice404 commented 8 years ago

That sounds good. I agree that the Java shouldn't ever call into the Clojure.

scottyw commented 8 years ago

I created TK-312 and assigned it to me.

cprice404 commented 8 years ago

@scottyw awesome, thanks.

@camlow325 shall we go ahead and merge this then?

camlow325 commented 8 years ago

All sounds good to me. :ship: