search

puppetlabs / clj-http-client

HTTP client library wrapping Apache HttpAsyncClient
Apache License 2.0
15 stars 30 forks source link

(TK-295) add tests for cookies #54

Closed janelu2 closed 8 years ago

janelu2 commented 8 years ago

This PR adds a test to see if cookies are being correctly stored and accessible since there already exists support for cookies.

janelu2 commented 8 years ago

@cprice404 @nathanielksmith

janelu2 commented 8 years ago

@cprice404 updated, lmk if that is what you were looking for?

cprice404 commented 8 years ago

+1 other than varname nitpick.

cprice404 commented 8 years ago

nice job

cprice404 commented 8 years ago

+1

janelu2 commented 8 years ago

@nathanielksmith any thoughts?

vilmibm commented 8 years ago

:+1:, only thought is wondering if we care about the async client? is that worth testing? or are the code paths so similar we can just test the sync client? (probs a question for @cprice404 )

cprice404 commented 8 years ago

:hankey: yeah, good call, it'd probably be a good idea to add analogs of these tests in the async test namespace.

cprice404 commented 8 years ago

+1 will merge after the trav