search

puppetlabs / clj-http-client

HTTP client library wrapping Apache HttpAsyncClient
Apache License 2.0
15 stars 30 forks source link

(TK-402) Allow metric namespace to be configurable #60

Closed rlinehan closed 8 years ago

rlinehan commented 8 years ago

Add two new client options - server-id and metric-prefix that allow the metric namespace to be configured rather than always puppetlabs.http-client.experimental.

If server-id is set, the metric namespace becomes puppetlabs.<server-id>.http-client.experimental.

If metric-prefix is set, the metric namespace becomes <metric-prefix>.http-client.experimental.

If both are set, metric-prefix wins out and a warning message is logged.

puppetcla commented 8 years ago

CLA signed by all contributors.

cprice404 commented 8 years ago

@jpinsonault / @camlow325 if one of you has a chance to do a second review on this today, would appreciate it.

jpinsonault commented 8 years ago

👍 This looks good to me, and like it was a bit tedious to do

Just one super minor nitpick, and @cprice404's docs question

rlinehan commented 8 years ago

@cprice404 @jpinsonault updated!

jpinsonault commented 8 years ago

@rlinehan those extra lines are still there, but I really don't care. I'm 👍 if you want to merge it @cprice404

rlinehan commented 8 years ago

Ahhhh what? Did I delete different extra lines? Ergh, wait, I'll update again.

rlinehan commented 8 years ago

I found one additional extra line... I amended my commit and force-pushed.