search

puppetlabs / clj-http-client

HTTP client library wrapping Apache HttpAsyncClient
Apache License 2.0
15 stars 30 forks source link

(TK-443) Allow turning off URL metrics #73

Closed justinstoller closed 7 years ago

justinstoller commented 7 years ago

The primary consumer for this library (puppetserver) passes metric ids for all metrics it's concerned about and does not need to use any of the autogenerated url metrics.

This patch allows configuring whether or not to generate url metrics. It parameterizes the clojure async and sync clients, and adds a commensurate field to ClientOptions for Java clients. The default is to enable url metrics for compatability.

The actual functionality was plumbed by @rlinehan

justinstoller commented 7 years ago

Ha! You reviewed it faster than I could request you review it, @rlinehan !

what do you think of it vs. enable-url-metrics?

I'm into changing it.

puppetcla commented 7 years ago

CLA signed by all contributors.

camlow325 commented 7 years ago

Ugh, the dreaded buffer overflow error in Travis:

*** buffer overflow detected ***: java terminated

@rlinehan - do you remember what we have to do to work around this in the Travis config?

justinstoller commented 7 years ago

(fistshake)

justinstoller commented 7 years ago