search

puppetlabs / clj-http-client

HTTP client library wrapping Apache HttpAsyncClient
Apache License 2.0
15 stars 30 forks source link

(PE-27189) disambiguate ambiguous type specifications #82

Closed jonathannewman closed 4 years ago

jonathannewman commented 4 years ago

Bumps clj-parent to 4.2.10

There have been issues seen with clj and java11 where clojure is unable to find the class associated with specific java interop calls. In this case, the "RequestOptions" constructor was occasionally ambigous. In order to rectify this issue, in all places where there is some ambiguity, type assertions are added.

In addition, there was some type issues with the common/RequestOptions ahd how it was handled. With the exiting code, there is one consistent path through RequestOptions that passes a URI. Schema type assertions were added to demonstrate and validate the behavior, and tests were created to demonstrate the correct handling of URL and URI types for url specification.

justinstoller commented 4 years ago

I ran the server tests on java 8 to see if there were any regressions. I saw none.

Ran 186 tests containing 2601 assertions.
0 failures, 0 errors.
puppetcla commented 4 years ago

CLA signed by all contributors.