(SERVER-2780) Add reason phrase to HTTP response

puppetlabs / clj-http-client

HTTP client library wrapping Apache HttpAsyncClient

Apache License 2.0

15 stars 30 forks source link

(SERVER-2780) Add reason phrase to HTTP response #84

Closed Magisus closed 4 years ago

Magisus commented 4 years ago

This commit adds an additional field to the Response object: the status message or reason phrase that goes along with the HTTP code. This allows us to better match the API for Puppet's HTTP response object, for ruby/java interop in puppetserver.

Magisus commented 4 years ago

Oh, hold on, wanted to add a test.

Magisus commented 4 years ago

Added.

Magisus commented 4 years ago

I thought about it, but I really just wanted to demonstrate that the API works. All of these mappings are built into the underlying apache library and definitely tested there. Maybe I could add one 404?

puppetcla commented 4 years ago

CLA signed by all contributors.