search

puppetlabs / control-repo

A control repository template
Apache License 2.0
203 stars 509 forks source link

Vagrantfile added? #1

Open alvagante opened 8 years ago

alvagante commented 8 years ago

Generally in the control-repos I do for different Puppet setups, I include a Vagrantfile and relevant scripts to be able to test locally the same Puppet and data. Would a PR with such an addition be welcomed? If so I can provide one.

bkc1 commented 8 years ago

+1 for a Vagrantfile to be included

npwalker commented 8 years ago

@alvagante I think we're trying to prevent this control-repo from doing too much. How tightly coupled does the Vagrantfile need to be to the control-repo?

Could there be a seperate repo for the Vagrantfile that includes instructions for how to add it to the control-repo?

Or could it be expected that the control-repo was cloned into a directory within the Vagrant directory?

I understand these might not be as elegant of a solution but going from a single clone to clone vagrantfile repo, cd, clone control-repo doesn't seem that bad. What do you think?

alvagante commented 8 years ago

@npwalker Well, in all my "control-repos" for different projects (didn't call them this way but they were doing the same thing) I've always found very useful a local vagrant environment where I could test quickly my changes to puppet code and data before committing them. Note that in Vagrant you'd have a multi VM environment with one vm per role, so the vagrant part is an essential part of the repo and has some coupling with the used roles. Having a separated Vagrant repo would do the same, but it would need some sync between the two repos. my2c