search

puppetlabs / control-repo

A control repository template
Apache License 2.0
205 stars 511 forks source link

Move profile::git_webhook into seperate module pe_code_manager_webhook #22

Closed npwalker closed 8 years ago

npwalker commented 8 years ago

Prior to this commit the functionality to setup the either code manager or zack/r10k was tightly coupled to this control-repo. In an effort to make that functionality useful to more people we're splitting it into a dedicated module.

After this commit, the pe_code_manager_webhook module will contain all logic around setting up the webhook while this control-repo will still gloss over the details needed to get everything in PE setup correctly to use that module.

This commit removes the files associated with the profile including some custom functions that were only there to make it work.

This commit removes the all_in_one_pe_2015_2 role as it was exactly the same as the all_in_one_pe role.

This commit modifies all_in_one_pe to use the pe_code_manager_webhook module instead of the profile.

natemccurdy commented 8 years ago

Looks good to me, and is following the theme of recent work to simplify the control-repo a bit.

:+1: