search

puppetlabs / control-repo

A control repository template
Apache License 2.0
205 stars 511 forks source link

Merge npwalker/control-repo in puppetlabs/control-repo #4

Closed npwalker closed 8 years ago

reidmv commented 8 years ago

There's a lot going on here and I'd love to see it evolve to be simpler to get set up. That said, this is a work in progress and importantly, this code is actually being used in the real world and iterated on. Merge it, I say! Can I get another :+1: ?

glarizza commented 8 years ago

I'm definitely :+1: but I also asked him to do it. It follows along the lines of what we're doing in the field, so this is great

glarizza commented 8 years ago

I'll give it until EOD today, if nobody dissents I'll hit the merge button. I use this on most of my gigs, so if something arises we'll file a PR and correct it.

trlinkin commented 8 years ago

Looking good to me! :+1:

I would like to see a Gemfile and Rakefile for some basic checks, but thats probably another PR

glarizza commented 8 years ago

With nobody dissenting, I'm merging!