search

puppetlabs / control-repo

A control repository template
Apache License 2.0
204 stars 510 forks source link

rubocop: scripts/config_version.rb - Useless assignment to variable - `e`. #66

Closed TJM closed 6 years ago

TJM commented 6 years ago

According to pdk validate (after running pdk convert)...

warning: rubocop: scripts/config_version.rb:5:21: Lint/UselessAssignment: Useless assignment to variable - `e`.
Nekototori commented 6 years ago

While I think rubocop error is good to fix, I'd argue that pdk isn't the appropriate tool for testing a control repo.

natemccurdy commented 6 years ago

Fixed in 36a278427582e6629141eb8539f658cf1604a528

Thanks for the report @TJM

TJM commented 6 years ago

@Nekototori - PDK's control-repo capability is under development or at least consideration: https://github.com/puppetlabs/pdk/issues/333

It already works just fine for pdk validate (and pdk convert makes it super easy), but I am not saying it couldn't be better (Puppetfile validation, etc) :)

TJM commented 6 years ago

Thanks @natemccurdy !

Nekototori commented 6 years ago

@TJM Thanks for the pointer. I see someone mentioned onceover which is generally what I recommend using for testing control repo. It handles Puppetfile validation, as well as quickly allowing you to update the modules in the Puppetfile and straight into testing how your puppetcode will handle the upgrade (in case there are changed/depreciated commands, etc).