search

puppetlabs / cpp-hocon

A C++ port of the Typesafe Config library.
Other
81 stars 57 forks source link

Added config resolver #107

Closed troizky closed 5 years ago

troizky commented 6 years ago

As it was suggested here https://github.com/puppetlabs/cpp-hocon/issues/105 Comparing to https://github.com/lightbend/config/blob/master/config/src/main/java/com/typesafe/config/impl/ConfigReference.java#L93, it looks like the fallback code at https://github.com/puppetlabs/cpp-hocon/blob/master/lib/src/values/config_reference.cc#L61 wasn't implemented.

puppetcla commented 6 years ago

CLA signed by all contributors.

MikaelSmith commented 6 years ago

Initial thought, is there a test case that covers these changes?

MikaelSmith commented 5 years ago

With the fallback code unused, and no tests, I don't feel comfortable merging this. If we find we need it in the future let's re-open it.