search

puppetlabs / dependency_checker

5 stars 11 forks source link

Rake is not a requirement and causes dependency chain issues with pdk #29

Closed logicminds closed 1 year ago

logicminds commented 3 years ago

Describe the bug Rake is not required to use the library but the dependency causes pdk's Gemfile to fail when using pdk bundle exec ruby -r 'puppet_litmus/rake_tasks' commands`

Remove the rake dependency from the gemspec and list as a development dependency instead

sanfrancrisko commented 3 years ago

Hi @logicminds - struggling to reproduce this issue. Could you perhaps provide a bit more context as to how this is being run?

I ran this against a new module:

# Creating a new module
pdk new module foo

# Running bundle install on it
cd foo
pdk bundle install

# Creating a small Ruby script and trying to exec ruby with the -r option
echo "puts 'hello'" > test.rb
pdk bundle exec ruby -r 'puppet_litmus/rake_tasks' test.rb
chelnak commented 1 year ago

Closing as this issue seems to have been inactive for some time now.