Closed joshcooper closed 7 months ago
Facter 4.5.2 returns the following:
C:\facter>bundle exec facter -j os.windows { "os.windows": { "edition_id": "ServerStandard", "installation_type": "Server", "product_name": "Windows Server 2019 Standard", "release_id": "1809", "system32": "C:\\Windows\\system32" } }
Facter 4.6.0 returns:
C:\facter>bundle exec facter -j os.windows { "os.windows": { "edition_id": 1, "installation_type": 1, "product_name": 1, "release_id": 1, "system32": "C:\\Windows\\system32" } }
It should return the same values as in facter 4.5.2.
C:\> cmd /c start /w msiexec /qn /i https://downloads.puppet.com/windows/puppet7/puppet-agent-7.29.0-x64.msi C:\> "C:\Program Files\Puppet Labs\Puppet\bin\facter" -j os.windows { "os.windows": { "edition_id": 1, "installation_type": 1, "product_name": 1, "release_id": 1, "system32": "C:\\Windows\\system32" } }
The regression was introduced in https://github.com/puppetlabs/facter/commit/2c291fea6acbdfe8cdbbc5535aa61086c27f9431#diff-10a200cea4737fabe6bb18f02ff3e23802ec3e6a4526577ac7ae917d1366ddca. The value parameter was misnamed.
value
Migrated issue to FACT-3455
Describe the Bug
Facter 4.5.2 returns the following:
Facter 4.6.0 returns:
Expected Behavior
It should return the same values as in facter 4.5.2.
Steps to Reproduce
Environment
Additional Context
The regression was introduced in https://github.com/puppetlabs/facter/commit/2c291fea6acbdfe8cdbbc5535aa61086c27f9431#diff-10a200cea4737fabe6bb18f02ff3e23802ec3e6a4526577ac7ae917d1366ddca. The
value
parameter was misnamed.