puppetlabs / forge_issues

This repository will allow public community members to file bug reports against the Puppet Forge
Creative Commons Zero v1.0 Universal
1 stars 0 forks source link

[Bug]: "Group by module" switch in download lists mislabeled? #15

Open smortex opened 5 months ago

smortex commented 5 months ago

What happened?

This switch makes me think:

The "Group by module" switch

Toggling it has no effect on sorting, but add/remove a column showing the latest release of a module, and remove/add the ability to unfold a module info to see the ChangeLog:

Toggled off Toggled on
off on

How I think it should behave

What browsers / clients are you seeing the problem on?

No response

Relevant log output

No response

Ramesh7 commented 5 months ago

Thank you, @smortex, for reporting and providing suggestions on how it should appear. Let me shed some light here to help you understand why it was designed that way.

Since you have a single entry (download) for the above modules, it may not seem to make much sense. However, consider a scenario where a customer is attempting to download multiple versions of a given module for different environment sets. When using group by, you will see the latest version you downloaded. If you expand that accordion, it will display a complete list of downloads the user has performed.

Similarly, if you opt to proceed without group by, you will encounter multiple entries of downloaded modules. Therefore, group by assists you in exploring all the modules you have downloaded, whereas proceeding without group by helps the user understand the various versions of the module they have downloaded.

Please let us know if this make sense or you have different thoughts or any better suggestion will happy to consider and implement in upcoming release. Thanks

skarwaperforce commented 1 month ago

Hey @smortex just going through the issues. Do you think this issue is still valid and needs looking at?

smortex commented 1 month ago

Hey @skarwaperforce

It looks like the toggle button still has the same behavior and the same wrong title, so at least fixing the label is still needed.