search

puppetlabs / gatling-puppet-load-test

34 stars 44 forks source link

(SLV-561) Create non-perf-agent-group add ntp #333

Closed johnduarte closed 5 years ago

johnduarte commented 5 years ago

This commit creates a non-perf-agent-group and adds the ntp class to it in order to ensure that ntp is installed and running on the puppet infrastructure nodes as well as the metrics node.

RandellP commented 5 years ago

@johnduarte I tried running performance_gatling with BEAKER_TESTS="" and the install failed...

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error w hile evaluating a Resource Statement, Class[Ntp]: parameter 'servers' expects an Array value, got String on node ip-10-2 27-2-251.amz-dev.puppet.net

johnduarte commented 5 years ago

@johnduarte I tried running performance_gatling with BEAKER_TESTS="" and the install failed...

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error w hile evaluating a Resource Statement, Class[Ntp]: parameter 'servers' expects an Array value, got String on node ip-10-2 27-2-251.amz-dev.puppet.net

This has been corrected with https://github.com/puppetlabs/gatling-puppet-load-test/pull/333/commits/dc2232cc99a84ff74c6918cb759ff0717f6225e1

RandellP commented 5 years ago

Tested and confirmed to work on standard ref arch.

billclaytor commented 5 years ago

I'm seeing KOs in my testing; hopefully this is just a glitch or error on my part in the setup. I'm repeating the test from scratch to verify the results but please hold off on merging until testing is complete. Thanks!

johnduarte commented 5 years ago

Tested using the performance rake task

$ git rev-parse HEAD
18956ecea9a67a0874e77083641ca3587a1dcec9

$ bundle exec ruby -v
ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-linux]

$ BEAKER_PE_VER=2019.2.0-rc9-23-g3e51e54 \
BEAKER_PE_DIR=http://enterprise.delivery.puppetlabs.net/2019.2/ci-ready \
BEAKER_INSTALL_TYPE=pe \
bundle exec rake performance
...
tests/ApplesToApples.rb passed in 16216.85 seconds
      Test Suite: tests @ 2019-09-23 16:59:57 -0700

      - Host Configuration Summary -

              - Test Case Summary for suite 'tests' -
       Total Suite Time: 16216.85 seconds
      Average Test Time: 16216.85 seconds
              Attempted: 1
                 Passed: 1
                 Failed: 0
                Errored: 0
                Skipped: 0
                Pending: 0
                  Total: 1
RandellP commented 5 years ago

@johnduarte Can you run a sim like Bill has been running to ensure we don't get unexpected KO's? I think he was running a scale sim.

edit: I misread the comment above as being only setup. Duh... looks good. I assume Bill will run one of his tests as well, so I won't duplicate that effort.