search

puppetlabs / gatling-puppet-load-test

34 stars 44 forks source link

(SLV-574) Enable gatling to use loadbalancer #338

Closed johnduarte closed 5 years ago

johnduarte commented 5 years ago

This PR enabled gatling to target a load balancer if it is present and to set the puppetserver auth.conf files on compile masters to allow for gatling submissions to be allowed.

RandellP commented 5 years ago

I ran some tests. Like I ran acceptance to make sure it still worked, and it did. I tried to run acceptance on the Large ref arch, but that failed. Though it wasn't due to any code changed here, and it has never been proven to work. But I feel confident that it won't break anything we currently run. So I approve.

johnduarte commented 5 years ago

I ran some tests. Like I ran acceptance to make sure it still worked, and it did. I tried to run acceptance on the Large ref arch, but that failed. Though it wasn't due to any code changed here, and it has never been proven to work. But I feel confident that it won't break anything we currently run. So I approve.

I am able to reproduce this failure using the acceptance test on a pe xl deploy with the following command.

bundle install rake pe_xl:deploy
PUPPET_GATLING_R10K_CONTROL_REPO=https://github.com/puppetlabs/puppetlabs-pe_perf_control_repo.git PUPPET_GATLING_R10K_BASEDIR=/etc/puppetlabs/code-staging/environments PUPPET_GATLING_R10K_ENVIRONMENTS=production  bundle exec beaker -h build/pe_xl/beaker.cfg  --debug --options setup/options/options_pe_xl.rb --tests tests/acceptance.rb

This failure is caused by ruby not being available on the PATH on the master host. When beaker is used to install PE it assigns privatebindir to the directory used for the puppet vendored binaries. Since beaker is not involved in installing PE in the pe_xl deploy, this value is empty, so the ruby command is not available to the command in the perf_run_helper that is used to execute the collect_metrics_files.rb script.

If I add ruby to the path on the master host and re-run the test it passes.

johnduarte commented 5 years ago

@RandellP I have added https://github.com/puppetlabs/gatling-puppet-load-test/pull/338/commits/d3a652f45ad143fd6f5e6d09d7aecaad05d555f0 to address the issue that you discovered.