search

puppetlabs / pdk-templates

The main template repo for the Puppet Development Kit https://github.com/puppetlabs/pdk
Apache License 2.0
46 stars 143 forks source link

Adjust with the new puppet specifications for module layouts #578

Open bastelfreak opened 1 month ago

bastelfreak commented 1 month ago

Use Case

https://github.com/puppetlabs/puppet-specifications/pull/157 defines which files are allowed in a module. pdk-templates should be updated so that new module builds only contain files within this list (work with an allow list, not a deny list). A common pattern is to use the .pmtignore config file.

Describe the Solution You Would Like

Implement new puppet module layout for module builds.

Describe Alternatives You've Considered

A clear and concise description of any alternative solutions or features you've considered.

Additional Context

Add any other context or screenshots about the feature request here.

jordanbreen28 commented 1 month ago

@bastelfreak pdk uses the .pdkignore file, which has its defaults defined here https://github.com/puppetlabs/pdk-templates/blob/b257ef101743e4dc4b9a7027d88db21c2faa9e4b/config_defaults.yml#L41

I think you're definitely right and we should strive to match the accepted module specification you linked, so I'll raise this with the team, thanks!