puppetlabs / pdk

The shortest path to better modules: Puppet Development Kit; Download:
https://puppet.com/download-puppet-development-kit
Apache License 2.0
225 stars 105 forks source link

(maint) Add an exclusion pin against rubocop modules #1365

Closed david22swan closed 5 months ago

david22swan commented 5 months ago

rubocop-factory_bot v2.26.0 and rubocop-rspec_rails v2.29.0 are both currently causing errors when run against our code and so these pins are being placed as a temporary fix while more investigation is done.

Example of error: Property AutoCorrect of cop FactoryBot/CreateList is supposed to be a boolean and contextual is not.

Checklist

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.24%. Comparing base (be66a64) to head (8702ee7).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1365 +/- ## ======================================= Coverage 88.24% 88.24% ======================================= Files 128 128 Lines 5435 5435 ======================================= Hits 4796 4796 Misses 639 639 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.