puppetlabs / pdksync

Manage large sets of modules with automation built on top of PDK
Apache License 2.0
13 stars 29 forks source link

Improve module validation performance #193

Closed seanmil closed 1 year ago

seanmil commented 1 year ago

Validate that each module exists only once, as that module is being processed.

Summary

During module cloning, the module validation function is called for all modules on each iteration through the module list, resulting in the cloning taking much longer than it needs to.

This change adjusts the code to validate one module at a time as that module is being processed.

Checklist

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

jordanbreen28 commented 1 year ago

Pulled and manually verified! Thanks again @seanmil!