puppetlabs / pdksync

Manage large sets of modules with automation built on top of PDK
Apache License 2.0
13 stars 29 forks source link

Ignore case when removing operating systems #221

Closed alex501212 closed 2 weeks ago

alex501212 commented 2 weeks ago

When running e.g. bundle exec rake 'pdksync:remove_platform_from_metadata[ubuntu, 18.04]' the os will not be removed from the metadata.json of a module due to the character casing not matching "Ubuntu"

To resolve this I have updated remove_platform_from_metadata so that when removing a platform the os character case is ignored

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.61%. Comparing base (ed674d4) to head (cb2de4c). Report is 7 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #221 +/- ## ========================================== + Coverage 45.55% 47.61% +2.05% ========================================== Files 10 10 Lines 1216 1216 ========================================== + Hits 554 579 +25 + Misses 662 637 -25 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.