Open alex501212 opened 2 weeks ago
Attention: Patch coverage is 11.11111%
with 8 lines
in your changes missing coverage. Please review.
Project coverage is 45.30%. Comparing base (
1698cbf
) to head (acb3757
).
Files with missing lines | Patch % | Lines |
---|---|---|
lib/pdksync/utils.rb | 11.11% | 8 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This is a good idea. But in terms of adding the "right" os support there isn't really a one size fits all. Every module probably has something different. A better approach would allow the user to:
I noticed that the update_os_support task has no functionality so I have implemented this task
I added the new update_os_support method to utils.rb and a supported_os_list.yaml in the conf folder.
This update_os_support will update the operating systems supported in a module's metadata.json and update it to match the OSes in the supported_os_list