search

puppetlabs / pdksync

Manage large sets of modules with automation built on top of PDK
Apache License 2.0
13 stars 29 forks source link

Implemented update os support #222

Open alex501212 opened 2 weeks ago

alex501212 commented 2 weeks ago

I noticed that the update_os_support task has no functionality so I have implemented this task

I added the new update_os_support method to utils.rb and a supported_os_list.yaml in the conf folder.

This update_os_support will update the operating systems supported in a module's metadata.json and update it to match the OSes in the supported_os_list

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 45.30%. Comparing base (1698cbf) to head (acb3757).

Files with missing lines Patch % Lines
lib/pdksync/utils.rb 11.11% 8 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #222 +/- ## ========================================== - Coverage 45.55% 45.30% -0.26% ========================================== Files 10 10 Lines 1216 1225 +9 ========================================== + Hits 554 555 +1 - Misses 662 670 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

logicminds commented 2 weeks ago

This is a good idea. But in terms of adding the "right" os support there isn't really a one size fits all. Every module probably has something different. A better approach would allow the user to:

  1. select from a list of support templates that pdksync has predefined
  2. allow the user to override specific groups of operating systems.