(REPLATS-101) Update spec helpers for > 1 image

puppetlabs / pupperware

Container fun time lives here.

Other

183 stars 67 forks source link

(REPLATS-101) Update spec helpers for > 1 image #232

Closed Iristyle closed 3 years ago

Iristyle commented 3 years ago

require_test_image can now understand a comma separated list of image names given to PUPPET_TEST_DOCKER_IMAGE and will return an array of image names rather than a string when that happens
pull_images can now accept an array of image names to ignore, rather than just a string

both changes are backwards compatible

Iristyle commented 3 years ago

It looks like this @nwolfe - https://github.com/puppetlabs/pe-console-services/pull/332/files#diff-b13e4282ffe92149a68a4cbed78d882e116b23ea348eed66646b3416a14c36caR10

I think I'm going to go a different direction on the RBAC / console split for now though and stick with producing just one configurable image... so I may end up closing this PR (not that it hurts / breaks anything)

Iristyle commented 3 years ago

Moved the rbac piece to https://github.com/puppetlabs/pupperware/pull/254

Turns out this is useful for a case where the same image is used in multiple services (as is the case with https://github.com/puppetlabs/r10k/pull/1143 ... and in pending changes to the puppet-agent test suite at https://github.com/puppetlabs/puppet-agent/pull/2079/files#diff-360a0bbca66cd1f28f3fd1a5f9a3b263eef4f39d9f1afd61dee2198027b936efR9)