(maint) Change ssl.sh interpreter to Bash

puppetlabs / pupperware

Container fun time lives here.

Other

183 stars 66 forks source link

(maint) Change ssl.sh interpreter to Bash #266

Closed Iristyle closed 3 years ago

Iristyle commented 3 years ago

While the shell script here is compatible with /bin/sh for historical reasons, there are some reasons to use /bin/bash - for instance, set -o pipefail

This impacts consumers like Connect / Cygnus and the PE Helm chart work.

Since we no longer care much about Alpine linux and using strictly POSIX, change the default interpreter.
An update will be made to pe-client-tools container to incorporate the updated version of this script

Iristyle commented 3 years ago

Certs are preloaded in the CI suite and container builds have to opt in to using this new version of ssl.sh (it's only used in client-tools container now), so I'm going to merge this to get the PR up there.

PR at https://github.com/puppetlabs/pe-client-tools-vanagon/pull/354

Iristyle commented 3 years ago

First shipped in pe client tools 19.8.8.23.ga5675c9 at https://github.com/puppetlabs/pe-client-tools-vanagon/actions/runs/1242228718