Approval Request: trepasi/geoip

pmcmaw commented 1 year ago

Puppet Module Approval Request

[ ] I can confirm I have checked my module against the Approved module criteria and I think it is a suitable candidate.

https://forge.puppet.com/modules/trepasi/geoip

Note: This has been sitting for a period of time, I came across and have created this issue on behalf of the owner: https://tickets.puppetlabs.com/browse/MODULES-11118

david22swan commented 1 year ago

Style - Modules is clean and easy to understand
Documentation - README and Reference both look good, no issues found
Maintenance and Lifecycle - Module look's to be maintained regularly, low amount of PRs but this seem's due to a lack of need rather than a lack of care.
License - Licensed under Apache
Originality - While two other modules of this type exist, neither has been updated for many years and are both of lower quality.
Metadata - Metadata is good
SemVer - Semantic versioning is used
Testing - Seem's robust and covers all functionality from what I can see, Unit tests currently failing due to issue with Setup, Acceptance tests have startup failures as well, but also some true ones.
Puppet Versions and Features - Module compatible with latest major release and not reliant on any unstable version.

david22swan commented 1 year ago

@rtibe If you still wish for your module to be set to approved I would be more than happy to do so once your tests are running green again. Also, if I don't respond fast enough to any updates on this Issue please feel free to ping me directly on the community slack, I'm joined under the name of David 'The Anvil'

rtib commented 1 year ago

I'll have a look on those tests soon and come back to this.

puppetlabs / puppet-approved-modules

Approval Request: trepasi/geoip #2

Puppet Module Approval Request