puppetlabs / puppet-approved-modules

0 stars 0 forks source link

Approval Request: trepasi-cassandra #3

Open pmcmaw opened 1 year ago

pmcmaw commented 1 year ago

Puppet Module Approval Request

https://forge.puppet.com/modules/trepasi/cassandra

Note: This has been sitting for a period of time, I came across and have created this issue on behalf of the owner: https://tickets.puppetlabs.com/browse/MODULES-11117

david22swan commented 1 year ago
david22swan commented 1 year ago

@rtib Taking a look at your module it has two issue that would need to be resolved before it could be approved:

rtib commented 1 year ago

Hi @david22swan ,

I've just seen you comments on the original ticket. Those acceptance tests are driving me nuts, they fail as soon the test suit tries to connect to the docker container. All functional requirements are covered in spec test, however, thus I could just auto-accept the failed acceptance stage tests.

Regarding community engagement, I'd be really happy to have contributors and co-maintainers, unfortunately it seems to be not a very popular topic. The "concurrent" Cassandra module, currently maintained by Vox Pupuli, originally developed by locp, is following a very different approach and not really interchangeable.

I'll have a look on the module, which might need some maintenance and we've plans for some more features which might become public this year.

rtib commented 1 year ago

Hi @david22swan , I've just updated the module to get it ready for stdlib 9 and also fixed the test pipeline.