search

puppetlabs / puppet-dev-tools

Puppet development tools in a Docker image
Apache License 2.0
12 stars 25 forks source link

(CDPE-4471) Install PDK 1.8.1 dependencies #104

Closed chrisleicester closed 3 years ago

chrisleicester commented 3 years ago

Prior to this change, if a customer built a module with PDK 1x, and attempted to use the puppet-dev-tools image in an airgapped environment, the test would fail because PDK would attempt to pull down dependencies of the historic version of PDK.

With this change, we brute-force the PDK 1x dependencies into the puppet-dev-tools image by installing the old version of PDK, creating a module, and running pdk validate and pdk test unit against it. We then clean up the test module, and continue to install the most recent PDK.

chrisleicester commented 3 years ago

@genebean I tested the image built from this code ^ and it doesn't work. The images have to get pulled down anyways.

We theorize that either:

  1. updating PDK deletes the dependencies
  2. PDK 2x looks for cached dependencies in a different place (ie we may need to manually copy them?

I'm not exactly sure whats happening. Feel free to dig in tomorrow and I'll ping you when I get in.