search

puppetlabs / puppet-dev-tools

Puppet development tools in a Docker image
Apache License 2.0
12 stars 25 forks source link

update onceover #117

Closed tuxmea closed 2 years ago

tuxmea commented 2 years ago

This patch update sonceover and adds several onceover addons like codequality (lint), octocatalog diff and the onceover lookup. octocatalog allows you to identify changes on servers by comparing the catalogs from branches onceover lookup is similar to puppet lookup but can be done without puppet server and root access.

tuxmea commented 2 years ago

@eputnam sorry for the late reply. I did the changes and updated the mr description.

eputnam commented 2 years ago

was the cmake install on here before? what is requiring that?

tuxmea commented 2 years ago

@eputnam sorry for the late reply. I had to dig for myself:

onceover-octocatalog-diff depends on octocatalog-diff which depends on rugged, which needs cmake.

The following error shows up on container build if we omit cmake:

#16 21.05 Gem::Ext::BuildError: ERROR: Failed to build gem native extension.
#16 21.05
#16 21.05     current directory: /usr/local/bundle/gems/rugged-1.5.0.1/ext/rugged
#16 21.05 /usr/local/bin/ruby -I /usr/local/lib/ruby/2.7.0 -r
#16 21.05 ./siteconf20220824-9-oycukh.rb extconf.rb
#16 21.05 checking for gmake... no
#16 21.05 checking for make... yes
#16 21.05 checking for cmake... no
#16 21.05 ERROR: CMake is required to build Rugged.
#16 21.05 *** extconf.rb failed ***
...
#16 21.05 In Gemfile:
#16 21.05   onceover-octocatalog-diff was resolved to 0.1.8, which depends on
#16 21.05     octocatalog-diff was resolved to 1.6.0, which depends on
#16 21.05       rugged