puppetlabs / puppet-editor-services

Puppet Language Server for editors
Apache License 2.0
45 stars 21 forks source link

(GH-213) Use Facts from the Sidecar #215

Closed glennsarti closed 4 years ago

glennsarti commented 4 years ago

Fixes #213

213 Part 2


Previously in commit 590804e the Sidecar was updated to retrieve facts however the object module was incorrectly setup to be used by the Language Server in-memory cache. This commit changes the protocol to have a Fact and FactList, similar to PuppetClass etc.


Now that facts can be loaded from the Sidecar, the FacterHelper needs to be updated to use these instead of calling Facter directly. This commit: