search

puppetlabs / puppet-editor-services

Puppet Language Server for editors
Apache License 2.0
45 stars 21 forks source link

Replace contributing.md and code_of_conduct #237

Closed jpogran closed 3 years ago

jpogran commented 4 years ago

Should this CODE_OF_CONDUCT.md be replaced by https://github.com/puppetlabs/.github/blob/master/CODE_OF_CONDUCT.md ?

(there's also a CONTRIBUTING.md, but I'm not so sure about that one)

Originally posted by @DavidS in https://github.com/puppetlabs/puppet-editor-services/pull/236

jpogran commented 4 years ago

The original CONTRIBUTING.md and CODE_OF_CONDUCT.mt came directly from Github suggestions, back when we were hosted in the Lingua org. They served as a good starting point for small projects.

Adopting the ones in the Puppet Github organization would bring us in line with company standards. In order to do this, according to https://help.github.com/en/articles/creating-a-default-community-health-file-for-your-organization, we would have to remove each file from our repo in order for the Puppet ones to show up.

After looking at a few Puppet repos, this doesn't seem to be followed everywhere and most have local versions and some differ from the Puppet namespace.

binford2k commented 4 years ago

fwiw, the .github repo is relatively new. Most pre-existing repositories haven't been switched over to use it.