(GH-238) Monkey patch Facter for minimal resets

puppetlabs / puppet-editor-services

Puppet Language Server for editors

Apache License 2.0

45 stars 21 forks source link

(GH-238) Monkey patch Facter for minimal resets #239

Closed glennsarti closed 4 years ago

glennsarti commented 4 years ago

Closes #238

It appears that Facter 4.0.16 is resetting the Facter search dirs which then causes the sidecar to not find some external or custom facts. This commit monkey patches the Facter module and makes it possible to limit the number of resets to one.

glennsarti commented 4 years ago

May or may not be required if https://tickets.puppetlabs.com/browse/FACT-2562 is merged and released in time.

glennsarti commented 4 years ago

@jpogran We should probably merge this (test now pass) and then possibly revert once Facter 4.0.17 is released with a fix. Until then all CI pipelines for this project will fail.

jpogran commented 4 years ago

Created new issue tracking reverting the path so we plan for it later, approving and merging this now