puppetlabs / puppet-editor-services

Puppet Language Server for editors
Apache License 2.0
45 stars 21 forks source link

(GH-252) Remove puppetstrings featureflag and remove support for Puppet 4 #247

Closed glennsarti closed 4 years ago

glennsarti commented 4 years ago

Fixes #252

The Language Server Sidecar needs to support both Puppet 5 and Puppet 6. Now that the puppet-strings feature is becoming mainstream, the puppet-strings code also needs to to support Puppet 5.

Unfortunately the Loaders in Puppet 5 are different than Puppet 6 therefore the Loader manipulation etc. can not work. But using the loaders is actually very complicated and could be prone to error in Puppet 7 and beyond.

This commit:


Now that puppet-strings is used for metadata information, support for Puppet 4 must be removed. Ths commit removes Puppet 4 from the testing matrix and modifies the Debug Server, Language Server and Language Server Sidecar to terminate early with an error if run under Puppet 4.

glennsarti commented 4 years ago

Self merging as this is in 1.0 and the failing cells are due to https://github.com/puppetlabs/puppet-editor-services/pull/253