puppetlabs / puppet-editor-services

Puppet Language Server for editors
Apache License 2.0
45 stars 21 forks source link

(GH-269) Fix Workspace Symbol Provider #271

Closed glennsarti closed 4 years ago

glennsarti commented 4 years ago

Fixes #269

Previously if nil was passed into the build_file_uri method it would raise an obtuse error. This commit instead returns nil of the path is nil, otherwise it attempts to build a URI for the path.


Previously the Workspace Symbol Provider was not outputting DataTypes and was unnecessarily output debuging information for Facts. This commit adds support for DataTypes and ignores Facts. This commit also updates typos in the code comments.

glennsarti commented 4 years ago

@jpogran merge-y merge-y ?