search

puppetlabs / puppet-editor-services

Puppet Language Server for editors
Apache License 2.0
45 stars 21 forks source link

(GH-189) Reset PuppetLint configuration for each call #286

Closed glennsarti closed 3 years ago

glennsarti commented 3 years ago

Fixes #189

Previously after a call to fix_validation_errors, many validation errors came in as hints not errors. This was due to PuppetLint not resetting the PuppetLint.configuration.fix setting between calls. This commit updates the validation provider to reset this setting each call. This commit also adds tests for this scenario.

jpogran commented 3 years ago

@glennsarti can your rebase with main and push so we can have a CI run for this with the new github actions stuff

glennsarti commented 3 years ago

@jpogran Done. You'll need to remove the Appveyor integration though as I (rightly) have no access there.