Open jiji606 opened 4 years ago
Hi @jiji606 , apologies for the delay in response. You are correct go to definition
currently only works for include statements. We did not have an explicit issue to point you at that documents that, so I will create one today. It's a feature are we will be working on for the next couple months
Looks like we'll need to add some more edgecases to here : https://github.com/lingua-pupuli/puppet-editor-services/blob/master/lib/puppet-languageserver/manifest/definition_provider.rb#L50-L54
create_resources
could be trickier
This issue has been marked stale because it has been open for more than 30 days with no activity. If this issue is still important to you, please comment to keep this issue open. If not, this will be closed in 5 days
ping. Keep it open.
Naughty bot. Keep this open.
I am missing this functionality also for the require
keyword.
What Versions are you running?
OS Version: vscode is running on Windows 10 with a remote environment on archlinux vm VSCode Version: 1.39.2 Puppet Extension Version: 0.21.0 PDK Version: 1.14.0
Using extension with puppet agent. Version: 5.5.16
What You Are Seeing?
Go to definition works when used with include statements but only then. for example: When I click on docker::compose in this line
include foo::bar
it will take me to myfoo
module andbar
class/defined resource. This will not work when line begins withcontain
or any other keyword.What is Expected?
When the line is for example like this:
contain foo::bar
I can still go to definition. It should also work fromcreate_resource
function likecreate_resource('foo::bar', hiera('foobars')
How Did You Get This To Happen? (Steps to Reproduce)
I clicked on
foo::bar
in acontain foo::bar
line and nothing happened. Same for any other module.Output Log
Log after I clicked a working definition:
Log after I clicked a not working one
Node defintion for reference
Module class for reference