(GH-300) Return nil for bad hover requests

puppetlabs / puppet-editor-services

Puppet Language Server for editors

Apache License 2.0

46 stars 21 forks source link

(GH-300) Return nil for bad hover requests #301

Closed glennsarti closed 3 years ago

glennsarti commented 3 years ago

Fixes #300

Previously, the hover provider would return a Hover object with null contents which is not allowed by the Language Server Protocol. This commit updates Editor Services to instead return nil when an error occurs during the resolution.

glennsarti commented 3 years ago

@jpogran Ready for review.