search

puppetlabs / puppet-editor-services

Puppet Language Server for editors
Apache License 2.0
46 stars 21 forks source link

GH-318 Used a realpath for load dependencies. #326

Closed bit0rez closed 1 year ago

bit0rez commented 1 year ago

Solving a load depenencies bug. Issue: https://github.com/puppetlabs/puppet-editor-services/issues/318

P.S.: Sorry if I'm doing something wrong. I'm not a Ruby developer and rarely commit in OpenSource projects.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

chelnak commented 1 year ago

@bit0rez this is pretty awesome. Thank you.

I've kicked the tests. Please can you sign the CLA while we wait for them to process?

chelnak commented 1 year ago

Hmm looks like the test suite needs some love.

Leave it with us.

bit0rez commented 1 year ago 
rubygems-update requires Ruby version >= 2.6.0. The current ruby version is 2.5.0.

The latest version of rubygems-update that requires Ruby version >= 2.3.0 is 3.3.26. I think you need to fix setup script for tests that installs the latest version of packages at now.

chelnak commented 1 year ago

Hello! I still haven't got round to looking at this but haven't forgotten. Had a few other priorities that needed my attention.

I'll take a look asap.