search

puppetlabs / puppet-editor-services

Puppet Language Server for editors
Apache License 2.0
45 stars 21 forks source link

Create a gem for puppet-editor-services #382

Open genebean opened 3 weeks ago

genebean commented 3 weeks ago

Summary

This PR adds a gemspec and executables that would be called from it. The three executables are variations of the same files that reside in the root of the repo.

Additional Context

The idea here is to make it easier for people like myself to install a local copy of puppet-editor-services. This will facilitate easier use as a language server in things like neovim. Additionally, my hope is to use this gem as the basis for a Nix package that I would maintain.

I do imagine that some more specific requirements could be added to the runtime dependencies listed in the gemspec - if you have feedback on that, I am happy to adjust.

Checklist

I didn't do the check list because I didn't do any changes to the code, this is just setting up packaging.

CLAassistant commented 3 weeks ago

CLA assistant check
All committers have signed the CLA.

genebean commented 3 weeks ago

BTW, I'd be happy to contribute a GitHub Action to build and publish the gem if y'all want.

jordanbreen28 commented 3 weeks ago

@genebean this is great, I'll bring this up with the team and we will get back to you on this!

david22swan commented 1 week ago

@genebean This looks like a good change to use, if you could fix the Rubocop error showing we could then look into testing this properly. Just as a note you seem to have pushed the actual gem that you built by accident, this would need to be removed.

Thank you for the work, this is an interesting piece that we feel is a good idea to move forward with.