Closed tuxmaster5000 closed 7 months ago
ekohl
commented
8 months ago This is because the gem was renamed but still occupies the same namespace as the old gem. If that's also present, this happens. As I hinted at in https://github.com/puppetlabs/puppet-lint/pull/158#discussion_r1350138839 (but could have been more explicit about).
GSPatton
commented
8 months ago hi @tuxmaster5000. Thanks for this! I think this is due to clashes with other dependencies in puppet-lint which use the puppet-lint gem which haven't been updated to use the new gem puppetlabs-puppet-lint. We're currently working on updating these dependencies
GSPatton
commented
8 months ago @ekohl am I right in saying this^^. I see you're talking about the old gem occupying the same namespace - by this do you mean that currently other dependencies are pulling in the old puppet-lint gem and are competing with the new gem for the puppet-lint namespace?
If not could you clarify what the issue is? We're currently troubleshooting
ekohl
commented
8 months ago I've seen this before. On Fedora Puppet is packaged without a puppet.gemspec while placing files in /usr/share/ruby/vendor_ruby/puppet, so bundler doesn't recognize it. So when I use bundle install on something that requires the puppet gem, it also installs to ~/.gem/ruby/gems/puppet-8.2.0/ (for example). Now you have 2 files that can match require 'puppet' and the Puppet namespace is ambiguous. This results in weird double loading as you see.
With this gem it's the same: PuppetLint is ambiguous as long as anything pulls in puppet-lint and puppetlabs-puppet-lint, you will have this problem. AFAIK Bundler doesn't allow you to specify conflicts.
The only safe thing I can think of is changing the namespace as well as the filenames. It may help to use require_relative everywhere instead of require, but I really doubt that's sufficient.
rismoney
commented
8 months ago I rolled back to an old spec helper like 5.0.3. I mentioned this issue in the chat and was directed here. I was sarcastically told to not be opportunistic about my gem handling... While I get changes need to be made, I think this has been a never ending struggle with puppet. I don't think that folks realize how this stuff resonates. I have been using puppet for over a decade, and think the ruby, gem handling, and flip-flopping on this topic has definitely alienated a fairly large percentage of the original user base. I personally know several people who switched tooling after the facter debacle.
People get fed up, and want real improvements without breakage and handling these exceptions out of the box, even if in the short term, extra code has to be written to handle dualities.
So I rolled back as a breakfix, created an internal issue, and now have to track properly getting off this old version to be on a 'modern' code path. If I am busy maintaining code bases for my linter, I am failing at the goals of devops.
markeganfuller
commented
7 months ago This seems to happen regardless of the existence of old versions.
In a clean Ubuntu 20.04 Docker container, installing only ruby/bundler and the gem version of puppetlabs-puppet-lint:
The error still occurs:
root@puppet-lint:/# puppet-lint --version
/var/lib/gems/2.7.0/gems/puppetlabs-puppet-lint-5.0.0/lib/puppet-lint.rb:255: warning: already initialized constant PuppetLint::CheckSlashComments
/var/lib/gems/2.7.0/gems/puppetlabs-puppet-lint-5.0.0/lib/puppet-lint.rb:255: warning: previous definition of CheckSlashComments was here
/var/lib/gems/2.7.0/gems/puppetlabs-puppet-lint-5.0.0/lib/puppet-lint.rb:255: warning: already initialized constant PuppetLint::CheckStarComments
...
puppet-lint 5.0.0In fact the errors appear in the Github Actions for this repository: https://github.com/puppetlabs/puppet-lint/actions/runs/6857416201/job/18646463943#step:7:8
Run bundle exec rake spec
bundle exec rake spec
shell: /usr/bin/bash -e {0}
env:
PUPPET_GEM_VERSION: ~> 7.0
/opt/hostedtoolcache/Ruby/2.7.8/x64/bin/ruby -I/home/runner/work/puppet-lint/puppet-lint/vendor/bundle/ruby/2.7.0/gems/rspec-core-3.12.2/lib:/home/runner/work/puppet-lint/puppet-lint/vendor/bundle/ruby/2.7.0/gems/rspec-support-3.12.1/lib /home/runner/work/puppet-lint/puppet-lint/vendor/bundle/ruby/2.7.0/gems/rspec-core-3.12.2/exe/rspec --pattern spec/\*\*\{,/\*/\*\*\}/\*_spec.rb --exclude-pattern spec/acceptance/\*\*/\*_spec.rb
/home/runner/work/puppet-lint/puppet-lint/lib/puppet-lint.rb:255: warning: already initialized constant PuppetLint::CheckStarComments
/home/runner/work/puppet-lint/puppet-lint/lib/puppet-lint.rb:255: warning: previous definition of CheckStarComments was here
/home/runner/work/puppet-lint/puppet-lint/lib/puppet-lint.rb:255: warning: already initialized constant PuppetLint::CheckSlashComments
/home/runner/work/puppet-lint/puppet-lint/lib/puppet-lint.rb:255: warning: previous definition of CheckSlashComments was here
ChrLau
commented
7 months ago We see this error too in our CI-Containers. We use onceover-codequality and apparently they released a new version (0.11.0 - see Issue 30: puppet-lint renamed to puppetlabs-puppet-lint ) with fixed dependencies.
Our Gemfile looks the following:
source 'https://internal-repository'
gem 'puppetlabs_spec_helper', '~>7.0.0'
gem 'puppet', '~>7.27.0'
gem 'onceover', '~>3.21'
gem 'onceover-codequality', '~>0.11'When our container is build, I can see that only the puppetlabs-puppet-lint is installed:
Fetching gem metadata from https://internal-repository...........
Resolving dependencies...
Fetching rake 13.1.0
Installing rake 13.1.0
Fetching base64 0.2.0
Fetching blockenspiel 0.5.0
Fetching public_suffix 5.0.3
Fetching backticks 1.0.5
Installing base64 0.2.0
Installing backticks 1.0.5
Installing blockenspiel 0.5.0
Using bundler 2.2.24
Fetching colored 1.2
Installing public_suffix 5.0.3
Fetching colored2 3.1.2
Fetching concurrent-ruby 1.2.2
Fetching cri 2.15.11
Installing colored 1.2
Installing colored2 3.1.2
Installing cri 2.15.11
Installing concurrent-ruby 1.2.2
Fetching deep_merge 1.2.2
Installing deep_merge 1.2.2
Fetching diff-lcs 1.5.0
Fetching erubi 1.12.0
Fetching hocon 1.4.0
Fetching thor 1.3.0
Installing erubi 1.12.0
Installing diff-lcs 1.5.0
Fetching faraday-net_http 3.0.2
Fetching ruby2_keywords 0.0.5
Installing hocon 1.4.0
Installing thor 1.3.0
Fetching fast_gettext 2.3.0
Fetching forwardable 1.3.3
Installing faraday-net_http 3.0.2
Installing forwardable 1.3.3
Installing ruby2_keywords 0.0.5
Installing fast_gettext 2.3.0
Fetching locale 2.1.3
Fetching singleton 0.2.0
Fetching racc 1.7.3
Fetching text 1.3.1
Installing singleton 0.2.0
Installing racc 1.7.3 with native extensions
Installing locale 2.1.3
Installing text 1.3.1
Fetching rchardet 1.8.0
Installing rchardet 1.8.0
Fetching little-plugger 1.1.4
Fetching jwt 2.7.1
Fetching hiera 3.12.0
Fetching log4r 1.1.10
Installing little-plugger 1.1.4
Installing hiera 3.12.0
Installing jwt 2.7.1
Fetching multi_json 1.15.0
Fetching minitar 0.9
Fetching mocha 1.16.1
Installing log4r 1.1.10
Fetching parallel 1.23.0
Installing parallel 1.23.0
Installing multi_json 1.15.0
Installing minitar 0.9
Installing mocha 1.16.1
Fetching scanf 1.0.0
Fetching semantic_puppet 1.1.0
Installing scanf 1.0.0
Installing semantic_puppet 1.1.0
Fetching pathspec 1.1.3
Installing pathspec 1.1.3
Fetching puppetlabs-puppet-lint 5.0.0
Installing puppetlabs-puppet-lint 5.0.0
Fetching rspec-support 3.12.1
Fetching unicode-display_width 2.5.0
Installing rspec-support 3.12.1
Installing unicode-display_width 2.5.0
Fetching rgen 0.9.1
Fetching yard 0.9.34
Installing rgen 0.9.1
Fetching versionomy 0.5.0
Installing versionomy 0.5.0
Installing yard 0.9.34
Fetching addressable 2.8.5
Fetching facter 4.5.1
Installing addressable 2.8.5
Installing facter 4.5.1
Fetching puppet-resource_api 1.9.0
Installing puppet-resource_api 1.9.0
Fetching faraday 2.7.11
Installing faraday 2.7.11
Fetching prime 0.1.2
Installing prime 0.1.2
Fetching parallel_tests 4.3.0
Installing parallel_tests 4.3.0
Fetching logging 2.3.1
Fetching terminal-table 3.0.2
Installing terminal-table 3.0.2
Installing logging 2.3.1
Fetching rspec-core 3.12.2
Installing rspec-core 3.12.2
Fetching rspec-expectations 3.12.3
Installing rspec-expectations 3.12.3
Fetching rspec-mocks 3.12.6
Installing rspec-mocks 3.12.6
Fetching git 1.18.0
Installing git 1.18.0
Fetching gettext 3.4.9
Fetching faraday-follow_redirects 0.3.0
Fetching rspec-github 2.4.0
Installing faraday-follow_redirects 0.3.0
Installing rspec-github 2.4.0
Fetching rspec_junit_formatter 0.6.0
Fetching rspec 3.12.0
Installing rspec_junit_formatter 0.6.0
Installing gettext 3.4.9
Installing rspec 3.12.0
Fetching puppet-strings 4.1.0
Fetching puppet_forge 5.0.3
Installing puppet-strings 4.1.0
Installing puppet_forge 5.0.3
Fetching puppetlabs-rspec-puppet 5.0.0
Installing puppetlabs-rspec-puppet 5.0.0
Fetching rspec-puppet 4.0.0
Installing rspec-puppet 4.0.0
Fetching puppet 7.27.0
Installing puppet 7.27.0
Fetching gettext-setup 1.1.0
Installing gettext-setup 1.1.0
Fetching r10k 4.0.0
Installing r10k 4.0.0
Fetching puppet-syntax 3.3.0
Installing puppet-syntax 3.3.0
Fetching puppetlabs_spec_helper 7.0.0
Installing puppetlabs_spec_helper 7.0.0
Fetching onceover 3.21.0
Installing onceover 3.21.0
Fetching onceover-codequality 0.11.0
Installing onceover-codequality 0.11.0
Bundle complete! 4 Gemfile dependencies, 69 gems now installed.Yet we receive the same errors and our CI-Pipelines fail.
kmille
commented
7 months ago I'm the maintainer of the Arch Linux AUR package. I also get the warnings running v5.0.0. Anything I can do? I'm not a ruby pro. Currently holding back the update.
ekohl
commented
7 months ago Right now I'd ignore version 5. There is work ongoing to research ways to make it less painful for the whole ecosystem
bastelfreak
commented
7 months ago @kmille hey, puppet package maintainer for Arch Linux here, please ignore the puppet-lint 5 release for now. You can also follow https://github.com/puppetlabs/puppet-lint/discussions/173
jordanbreen28
commented
7 months ago Hi everyone,
Apologies for the inconvenience all this caused.
We have rolled back the v5.0.0 release of puppetlabs-puppet-lint, so removing this gem from your bundle environments should eliminate the conflicts and thus the warnings.
It worths noting we will be sticking with puppet-lint from now on, so this should not happen again.
If you're pulling the puppet-lint gem in through puppetlabs_spec_helper, v7.0.1 was released yesterday which should now pull in the correct gem.
Thanks!
On usage ton's of warnings are logged: