search

puppetlabs / puppet-lint

Check that your Puppet manifests conform to the style guide
https://puppetlabs.github.io/puppet-lint/
MIT License
18 stars 12 forks source link

Fix puppet-lint namespace clash with new puppetlabs-lint gem #170

Closed GSPatton closed 7 months ago

GSPatton commented 8 months ago

Currently, the new puppet-lint gem and the old one clash as both compete for the PuppetLint namespace. This initial commit aims to solve this by intorducing the puppetlabs directory in lib so that resources are found in lib/puppetlabs/puppet-lint rather than lib/puppet-lint. This method is being tested first to avoid introducing changes that would require users to update their puppet-lint resource definitions

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

bastelfreak commented 8 months ago

@GSPatton can you please rebase? I think we should test one of the external plugins with this branch before merging.

GSPatton commented 8 months ago

hi @bastelfreak. Will test that out now

ekohl commented 7 months ago

Just a thought: perhaps pick a name that really is different, like puppet-cop (after RuboCop).

GSPatton commented 7 months ago

Hi @ekohl, instead of changing all instances of PuppetLint we added the puppetlabs directory into lib to change the directory structure and thereby hopefully not overlap namespaces with the old gem. This has been tested and works. But please test it out and let us know if you find anything.

jordanbreen28 commented 7 months ago

Closing in favour of https://github.com/puppetlabs/puppet-lint/pull/177