Closed gerases closed 4 months ago
Hi, are you aware of https://rubygems.org/gems/puppet-lint-strict_indent-check ? It also checks the alignment
Hi, are you aware of https://rubygems.org/gems/puppet-lint-strict_indent-check ? It also checks the alignment
Yes, I do have that installed but it wasn't catching this situation.
@gerases apologies for the such late response.. I've left a couple of comments above. Could you address those and we can try get this moving? We also need you to sign the CLA. Thanks for your work on this :)
@gerases apologies for the such late response..
@jordanbreen28 , ah, good point -- just changed and pushed -- is that better?
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
05af720
) 93.15% compared to head (82ecfc7
) 93.19%.
Files | Patch % | Lines |
---|---|---|
...int/plugins/check_whitespace/space_before_arrow.rb | 95.83% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@gerases could you sign the CLA? I've tested this locally and all works like a charm :)
@gerases could you sign the SLA? I've tested this locally and all works like a charm :)
I think I did but it's still saying pending?
@gerases ah! its been known to do this.
re-opening
Looks like this is the issue https://github.com/cla-assistant/cla-assistant/issues/562#issuecomment-619914668 You need to set your email via git config and then commit
Looks like this is the issue cla-assistant/cla-assistant#562 (comment) You need to set your email via git config and then commit
okeedok, working on this right now
Hmm, i can't seem to do anything here, should close the PR and create a new one?
Hmm, i can't seem to do anything here, should close the PR and create a new one?
@gerases It looks like you're commits are authored by a different email/user than your PR was created with (which is probably what you used to sign the CLA) 😃
Yeah, needed to rewrite the commits, should be good now
@bastelfreak, can you approve
Thanks for your contribution @gerases 😁
@jordanbreen28 , happy to contribute! Thank you all as well!
This will trigger a warning only for resources with single parameters such as:
Summary
Create a new plugin for ensuring a single space before a '=>' in resources with a single parameter. Arrow alignment for resources with multiple parameters (including detecting extra white space before the arrow) is already done in the arrow_alignment plugin.
Checklist