search

puppetlabs / puppet-lint

Check that your Puppet manifests conform to the style guide
https://puppetlabs.github.io/puppet-lint/
MIT License
18 stars 12 forks source link

support for pre-commit tool in puppet-lint #202

Closed kbroch-rivosinc closed 3 weeks ago

kbroch-rivosinc commented 1 month ago

Use Case

pre-commit tool is used to install and manage git hooks. Currently puppet-lint has a mirror https://github.com/pre-commit/mirrors-puppet-lint to accomplish this. In general this works but can become out of sync with the latest release of puppet-lint. Wondering if puppetlabs would be interested in supporting this directly.

Describe the Solution You Would Like

There are two possible solutions:

Describe Alternatives You've Considered

I tried a PR https://github.com/pre-commit/mirrors-puppet-lint/pull/8 but it wasn't correct and closed.

Additional Context

I appreciate when maintainers of the tool add the pre-commit cfg as it adds validity to the cfg (ex: black ) and also it removes this maintainance task for pre-commit maintainers (I know it moves it to your plate).

I'm happy to help with PR if this seems like a feature you'd entertain.

kbroch-rivosinc commented 3 weeks ago

Closing this as the original repo has updated. I'm guessing there was a stale token and the GH actions stopped running 5 months ago. Now github-action bot is checking daily as before.