search

puppetlabs / puppet-runtime

runtime dependencies for Vanagon projects
Apache License 2.0
5 stars 88 forks source link

updated packages for bolt release #888

Closed alex501212 closed 2 months ago

alex501212 commented 2 months ago

Updates packages for ruby 3 + puppet 8

donoghuc commented 2 months ago

Not quite following the reverts etc you made. I was pointing out that when you ad a new case you must also implement logic to select that case conditionally. One option would be to explicitly call it out in project files, however i'm not convinced that is the best long term solution. Instead i think we should investigate switching on ruby version.

joshcooper commented 2 months ago

Before merging, could you squash commits and remove any merge commits from your feature branch?

Also I recommend running this rake task to show how each project in this repo will be modified for a given platform:

$ bundle exec rake vanagon:component_diff -- -P all -p el-9-x86_64 --from upstream/master --to HEAD

For the most accurate results, you'll want to rebase your feature branch onto upstream/master (where upstream is the remote for puppetlabs)

donoghuc commented 2 months ago

Thanks @joshcooper , i'm going to take over this work. I'll likely just start a new PR.