search

puppetlabs / puppet-runtime

runtime dependencies for Vanagon projects
Apache License 2.0
5 stars 88 forks source link

(CAT-643) - Add puppet_forge to pdk-runtime #919

Closed danadoherty639 closed 1 month ago

danadoherty639 commented 1 month ago

This PR adds 5.0.4 puppet forge gem as a component and a dependency to the PDK project

dependencies of puppet-forge gem: faraday ~> 2.0 -> v2.12.0 added as component faraday-follow_redirects ~> 0.3.0 -> added as component minitar < 1.0.0 -> v0.9.0 already present in runtime semantic_puppet ~> 1.0 -> semantic puppet version 1.1.0 already present in runtime (default version)

https://jenkins-platform.delivery.puppetlabs.net/view/vanagon-generic-builder/job/platform_vanagon-generic-builder_vanagon-packaging_generic-builder/3293/

joshcooper commented 1 month ago

Changes look good, only the pdk-runtime is affected (at least on RHEL 7)

$ bundle exec rake vanagon:component_diff -- --from dd4b02c --to HEAD --project all --platform el-7-x86_64
...
Here is what your code changes would affect:

Project pe-bolt-server-runtime-2023.8.x
Nothing is affected 😊
Project pe-installer-runtime-main
Nothing is affected 😊
Project pe-bolt-server-runtime-main
Nothing is affected 😊
Project agent-runtime-7.x
Nothing is affected 😊
Project pe-bolt-server-runtime-2021.7.x
Nothing is affected 😊
Project pe-installer-runtime-2021.7.x
Nothing is affected 😊
Project bolt-runtime
Nothing is affected 😊
Project pdk-runtime

Platform name: el-7-x86_64
    Component 'rubygem-faraday' was newly added, not showing diff for it

    Component 'rubygem-faraday-follow_redirects' was newly added, not showing diff for it

    Component 'rubygem-faraday-net_http' was newly added, not showing diff for it

    Component 'rubygem-puppet_forge' was newly added, not showing diff for it

    Component 'rubygem-semantic_puppet' was newly added, not showing diff for it

Project client-tools-runtime-2023.8.x
Nothing is affected 😊
Project client-tools-runtime-main
Nothing is affected 😊
Project pe-installer-runtime-2023.8.x
Nothing is affected 😊
Project client-tools-runtime-2021.7.x
Nothing is affected 😊
Project agent-runtime-main
Nothing is affected 😊

One nit, could you update your commit message to describe why the puppet_forge gem is being added and why the other gems were bumped?

Also could you attempt to build the pdk runtime in the vanagon-generic-builder job https://jenkins-platform.delivery.puppetlabs.net/view/vanagon-generic-builder/job/platform_vanagon-generic-builder_vanagon-generic-builder-init_generic-builder/? You'll need to point it to your github username, repo, branch, vanagon project and vanagon build targets. It's a good idea to try to build on at least one platform of each supported OS (RHEL, Ubuntu, Windows, macOS)

danadoherty639 commented 1 month ago

Changes look good, only the pdk-runtime is affected (at least on RHEL 7)

$ bundle exec rake vanagon:component_diff -- --from dd4b02c --to HEAD --project all --platform el-7-x86_64
...
Here is what your code changes would affect:

Project pe-bolt-server-runtime-2023.8.x
Nothing is affected 😊
Project pe-installer-runtime-main
Nothing is affected 😊
Project pe-bolt-server-runtime-main
Nothing is affected 😊
Project agent-runtime-7.x
Nothing is affected 😊
Project pe-bolt-server-runtime-2021.7.x
Nothing is affected 😊
Project pe-installer-runtime-2021.7.x
Nothing is affected 😊
Project bolt-runtime
Nothing is affected 😊
Project pdk-runtime

Platform name: el-7-x86_64
    Component 'rubygem-faraday' was newly added, not showing diff for it

    Component 'rubygem-faraday-follow_redirects' was newly added, not showing diff for it

    Component 'rubygem-faraday-net_http' was newly added, not showing diff for it

    Component 'rubygem-puppet_forge' was newly added, not showing diff for it

    Component 'rubygem-semantic_puppet' was newly added, not showing diff for it

Project client-tools-runtime-2023.8.x
Nothing is affected 😊
Project client-tools-runtime-main
Nothing is affected 😊
Project pe-installer-runtime-2023.8.x
Nothing is affected 😊
Project client-tools-runtime-2021.7.x
Nothing is affected 😊
Project agent-runtime-main
Nothing is affected 😊

One nit, could you update your commit message to describe why the puppet_forge gem is being added and why the other gems were bumped?

Also could you attempt to build the pdk runtime in the vanagon-generic-builder job https://jenkins-platform.delivery.puppetlabs.net/view/vanagon-generic-builder/job/platform_vanagon-generic-builder_vanagon-generic-builder-init_generic-builder/? You'll need to point it to your github username, repo, branch, vanagon project and vanagon build targets. It's a good idea to try to build on at least one platform of each supported OS (RHEL, Ubuntu, Windows, macOS)

Hey Josh I thought the vanagon-builder init jenkins step has already been done, I attached the link in the description?

joshcooper commented 1 month ago

I attached the link in the description

Oh sorry, I missed that. Looks good.