search

puppetlabs / puppet-specifications

Specification of the Puppet Language, Catalog, Extension points
Other
99 stars 66 forks source link

(FM-7596) Draft of RSAPI Transport layer #133

Closed da-ar closed 5 years ago

da-ar commented 5 years ago

Not happy with the transport implementation being described here, I think we need an interface class.

Added file paths to the code samples, as in @DavidS notes. I think they help make things clearer.

da-ar commented 5 years ago

+1

DavidS commented 5 years ago

@clairecadman can you have a quick look over the changes here, and apply your magic, please?

clairecadman commented 5 years ago

@DavidS Yes I'll take a look this afternoon!

clairecadman commented 5 years ago

@DavidS I made a couple of minor edits. But line 453 needs to be fixed, I'm just not sure what it means. Thanks!

da-ar commented 5 years ago

@DavidS reminder that you have some local changes to push.