puppetlabs / puppet-specifications

Specification of the Puppet Language, Catalog, Extension points
Other
99 stars 66 forks source link

(MODULES-9428) Clarify composite namevar edgecases and add examples #140

Closed DavidS closed 5 years ago

DavidS commented 5 years ago

I'll come back to this after contributor summit.

DavidS commented 5 years ago

I've found a few more tickets that fold into the composite namevars issue that I'd like to bundle into this fix:

PDK-1220 is already covered in this text, the others need a bit more consideration.


against my usual preferences in this repo, I've rebased and munged the commits on this change as far as it went to separate the editorial and the content changes.

DavidS commented 5 years ago

@Lavinia-Dan @da-ar this is now in a shape to review. Note that the commits are broken up into distinct chunks that should help reduce clutter during reviewing.

DavidS commented 5 years ago

Ok, I think this wraps it up. The implementation is available at https://github.com/puppetlabs/puppet-resource_api/pull/174 and there don't seem to be further comments here.