search

puppetlabs / puppet-specifications

Specification of the Puppet Language, Catalog, Extension points
Other
99 stars 66 forks source link

(GH-225) Add custom_insync to rsapi docs #153

Closed michaeltlombardi closed 3 years ago

michaeltlombardi commented 3 years ago

This PR coincides with the work for puppetlabs/puppet-resource_api#225 to add the new custom_insync feature and functionality to rsapi resources;

It covers a common use case in the code and explains the purpose and some implementation concerns.

michaeltlombardi commented 3 years ago

@clairecadman just pinging to see if my updates addressed your review comments :)

clairecadman commented 3 years ago

@michaeltlombardi yes all good thanks! I don't want to change anything else as it would make it inconsistent with the rest of the README.

michaeltlombardi commented 3 years ago

@clairecadman, @DavidS, can we get a final approval and merge on this if there's nothing else?