search

puppetlabs / puppet-specifications

Specification of the Puppet Language, Catalog, Extension points
Other
99 stars 66 forks source link

(PA-24) File Path specifications changes for PXP-Agent #57

Closed jcoconnor closed 9 years ago

jcoconnor commented 9 years ago

Update to the file_path.md file to capture recent pxp-agent changes

jcoconnor commented 9 years ago

@Iristyle Looks like we ship the Unit Tests .exe. (e.g. cpp-pcp-client-unittests.exe) - I checked on facter and these are not listed in the spec - is this ok ?

Would a more general ticket be worthwhile to trawl through all the directories to make sure the spec is up to date ?

richardc commented 9 years ago

We probably shouldn't ship unittests.exe, they're not intended to work outside of a checkout in a development/build cycle. I'd hope it's just a cmake change to mark it as something to build and not install.

jcoconnor commented 9 years ago

@Iristyle Have just updated the lib*.dll comments for both pxp-agent and puppet-agent.

What do you mean "Could we also add libeay32.dll to the OpenSSL section with ssleay32.dll?" ? Do you mean fixing the files/comments for "C:\Program Files\Puppet Labs\Puppet\sys" ?

Iristyle commented 9 years ago

@jcoconnor yes, I mean adding to the section for C:\Program Files\Puppet Labs\Puppet\sys. pxp-agent also attempts to load libeay32.dll, so I figured it was worth mentioning there as well.

richardc commented 9 years ago

:+1: this looks sane to me.